fix: Remove unused fixtures and fix test name in smart swaps disabled spec #25616

plasmacorral · 2024-07-01T19:11:13Z

Description

Test name was not being captured correctly and recently came to appreciate that some of the snap account related fixtures were not actually needed for this test.

Updated test name and removed accountSnapFixtures

Related issues

Fixes: 505

Manual testing steps

Firefox:
yarn build:test:mv2 then ENABLE_MV3=false yarn test:e2e:single test/e2e/accounts/smart-swap-disabled.spec.ts --browser=firefox
Chrome:
yarn build:test then yarn test:e2e:single test/e2e/accounts/smart-swap-disabled.spec.ts --browser=chrome

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-07-01T19:11:23Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

codecov · 2024-07-01T19:23:55Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.60%. Comparing base (198bedd) to head (52bc178).

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #25616   +/-   ##
========================================
  Coverage    69.60%   69.60%           
========================================
  Files         1364     1364           
  Lines        48172    48172           
  Branches     13291    13291           
========================================
  Hits         33526    33526           
  Misses       14646    14646

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

metamaskbot · 2024-07-01T19:35:24Z

Builds ready [cedb87c]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (152 ± 187 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	63	119	92	18	8
		domContentLoaded	9	51	24	11	5
		load	39	1850	152	390	187
		domInteractive	9	51	24	11	5

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

gantunesr

Since you're already changing this file, lets update the name of the test

describe('Snap Account - Smart Swaps', function (this: Suite) {
  it('checks if smart swaps are disabled for snap accounts', async function () {
    ...
  }
}

test/e2e/accounts/smart-swap-disabled.spec.ts

sonarcloud · 2024-07-02T01:15:29Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

metamaskbot · 2024-07-02T01:50:07Z

Builds ready [52bc178]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (65 ± 8 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	67	123	90	15	7
		domContentLoaded	9	48	24	12	6
		load	43	102	65	16	8
		domInteractive	9	48	24	12	6

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

chloeYue

LGTM! Thanks for adjusting this !

Remove unused fixtures and fix test name

cedb87c

plasmacorral self-assigned this Jul 1, 2024

plasmacorral added team-accounts e2e-test End to end test for the MetaMask extension type-bug labels Jul 1, 2024

plasmacorral marked this pull request as ready for review July 1, 2024 20:27

plasmacorral requested a review from a team as a code owner July 1, 2024 20:27

plasmacorral added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jul 1, 2024

gantunesr reviewed Jul 2, 2024

View reviewed changes

test/e2e/accounts/smart-swap-disabled.spec.ts Outdated Show resolved Hide resolved

plasmacorral added 2 commits July 1, 2024 20:54

Merge branch 'develop' into fix-e2e-test-name-smart-swap-disabled

8c0c337

use import instead of require, and update test name

52bc178

plasmacorral requested a review from gantunesr July 2, 2024 01:50

chloeYue approved these changes Jul 2, 2024

View reviewed changes

seaona approved these changes Jul 2, 2024

View reviewed changes

plasmacorral merged commit 95407cc into develop Jul 2, 2024
73 checks passed

plasmacorral deleted the fix-e2e-test-name-smart-swap-disabled branch July 2, 2024 14:30

github-actions bot locked and limited conversation to collaborators Jul 2, 2024

github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jul 2, 2024

metamaskbot added the release-12.2.0 Issue or pull request that will be included in release 12.2.0 label Jul 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Remove unused fixtures and fix test name in smart swaps disabled spec #25616

fix: Remove unused fixtures and fix test name in smart swaps disabled spec #25616

plasmacorral commented Jul 1, 2024 •

edited

Loading

github-actions bot commented Jul 1, 2024

codecov bot commented Jul 1, 2024 •

edited

Loading

metamaskbot commented Jul 1, 2024

gantunesr left a comment

sonarcloud bot commented Jul 2, 2024

metamaskbot commented Jul 2, 2024

chloeYue left a comment

fix: Remove unused fixtures and fix test name in smart swaps disabled spec #25616

fix: Remove unused fixtures and fix test name in smart swaps disabled spec #25616

Conversation

plasmacorral commented Jul 1, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Jul 1, 2024

codecov bot commented Jul 1, 2024 • edited Loading

Codecov Report

metamaskbot commented Jul 1, 2024

gantunesr left a comment

Choose a reason for hiding this comment

sonarcloud bot commented Jul 2, 2024

Quality Gate passed

metamaskbot commented Jul 2, 2024

chloeYue left a comment

Choose a reason for hiding this comment

plasmacorral commented Jul 1, 2024 •

edited

Loading

codecov bot commented Jul 1, 2024 •

edited

Loading